From 0d5f0f55c2c6b6394e592e9d688c77356d36c8d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20San=20Jos=C3=A9?= Date: Fri, 29 May 2026 10:03:21 +0200 Subject: [PATCH] Lint fixes --- src/resolve-tools-input.test.ts | 244 ++++++++++++++------------------ src/resolve-tools-input.ts | 4 +- 2 files changed, 111 insertions(+), 137 deletions(-) diff --git a/src/resolve-tools-input.test.ts b/src/resolve-tools-input.test.ts index d6da2fa5d..d281eb3d5 100644 --- a/src/resolve-tools-input.test.ts +++ b/src/resolve-tools-input.test.ts @@ -7,165 +7,137 @@ import { getRecordingLogger, LoggedMessage, setupTests } from "./testing-utils"; setupTests(test); -test( - "resolveToolsInput returns undefined when no tools input or repository property is set", - (t) => { - const loggedMessages: LoggedMessage[] = []; - const logger = getRecordingLogger(loggedMessages); +test("resolveToolsInput returns undefined when no tools input or repository property is set", (t) => { + const loggedMessages: LoggedMessage[] = []; + const logger = getRecordingLogger(loggedMessages); - const result = resolveToolsInput(undefined, {}, logger); + const result = resolveToolsInput(undefined, {}, logger); - t.is(result, undefined); - t.is(loggedMessages.length, 0); - }, -); + t.is(result, undefined); + t.is(loggedMessages.length, 0); +}); -test( - "resolveToolsInput returns workflow input when only workflow input is provided", - (t) => { - const loggedMessages: LoggedMessage[] = []; - const logger = getRecordingLogger(loggedMessages); +test("resolveToolsInput returns workflow input when only workflow input is provided", (t) => { + const loggedMessages: LoggedMessage[] = []; + const logger = getRecordingLogger(loggedMessages); - const result = resolveToolsInput("latest", {}, logger); + const result = resolveToolsInput("latest", {}, logger); - t.is(result, "latest"); - t.is(loggedMessages.length, 1); - t.is( - loggedMessages[0].message, - "Setting tools: latest based on workflow input.", - ); - }, -); + t.is(result, "latest"); + t.is(loggedMessages.length, 1); + t.is( + loggedMessages[0].message, + "Setting tools: latest based on workflow input.", + ); +}); -test( - "resolveToolsInput returns repository property when only repository property is provided", - (t) => { - const loggedMessages: LoggedMessage[] = []; - const logger = getRecordingLogger(loggedMessages); +test("resolveToolsInput returns repository property when only repository property is provided", (t) => { + const loggedMessages: LoggedMessage[] = []; + const logger = getRecordingLogger(loggedMessages); - const repositoryProperties: RepositoryProperties = { - [RepositoryPropertyName.TOOLS]: "toolcache", - }; - const result = resolveToolsInput(undefined, repositoryProperties, logger); + const repositoryProperties: RepositoryProperties = { + [RepositoryPropertyName.TOOLS]: "toolcache", + }; + const result = resolveToolsInput(undefined, repositoryProperties, logger); - t.is(result, "toolcache"); - t.is(loggedMessages.length, 1); - t.is( - loggedMessages[0].message, - "Setting tools: toolcache based on the 'github-codeql-tools' repository property.", - ); - }, -); + t.is(result, "toolcache"); + t.is(loggedMessages.length, 1); + t.is( + loggedMessages[0].message, + "Setting tools: toolcache based on the 'github-codeql-tools' repository property.", + ); +}); -test( - "resolveToolsInput prioritizes workflow input over repository property", - (t) => { - const loggedMessages: LoggedMessage[] = []; - const logger = getRecordingLogger(loggedMessages); +test("resolveToolsInput prioritizes workflow input over repository property", (t) => { + const loggedMessages: LoggedMessage[] = []; + const logger = getRecordingLogger(loggedMessages); - const repositoryProperties: RepositoryProperties = { - [RepositoryPropertyName.TOOLS]: "toolcache", - }; - const result = resolveToolsInput("nightly", repositoryProperties, logger); + const repositoryProperties: RepositoryProperties = { + [RepositoryPropertyName.TOOLS]: "toolcache", + }; + const result = resolveToolsInput("nightly", repositoryProperties, logger); - t.is(result, "nightly"); - t.is(loggedMessages.length, 1); - t.is( - loggedMessages[0].message, - "Setting tools: nightly based on workflow input.", - ); - }, -); + t.is(result, "nightly"); + t.is(loggedMessages.length, 1); + t.is( + loggedMessages[0].message, + "Setting tools: nightly based on workflow input.", + ); +}); -test( - "resolveToolsInput treats empty string workflow input as not set", - (t) => { - const loggedMessages: LoggedMessage[] = []; - const logger = getRecordingLogger(loggedMessages); +test("resolveToolsInput treats empty string workflow input as not set", (t) => { + const loggedMessages: LoggedMessage[] = []; + const logger = getRecordingLogger(loggedMessages); - const repositoryProperties: RepositoryProperties = { - [RepositoryPropertyName.TOOLS]: "toolcache", - }; - const result = resolveToolsInput("", repositoryProperties, logger); + const repositoryProperties: RepositoryProperties = { + [RepositoryPropertyName.TOOLS]: "toolcache", + }; + const result = resolveToolsInput("", repositoryProperties, logger); - t.is(result, "toolcache"); - t.is(loggedMessages.length, 1); - t.is( - loggedMessages[0].message, - "Setting tools: toolcache based on the 'github-codeql-tools' repository property.", - ); - }, -); + t.is(result, "toolcache"); + t.is(loggedMessages.length, 1); + t.is( + loggedMessages[0].message, + "Setting tools: toolcache based on the 'github-codeql-tools' repository property.", + ); +}); -test( - "resolveToolsInput returns workflow input with URL value", - (t) => { - const loggedMessages: LoggedMessage[] = []; - const logger = getRecordingLogger(loggedMessages); +test("resolveToolsInput returns workflow input with URL value", (t) => { + const loggedMessages: LoggedMessage[] = []; + const logger = getRecordingLogger(loggedMessages); - const url = "https://example.com/codeql-bundle.tar.gz"; - const result = resolveToolsInput(url, {}, logger); + const url = "https://example.com/codeql-bundle.tar.gz"; + const result = resolveToolsInput(url, {}, logger); - t.is(result, url); - t.is(loggedMessages.length, 1); - t.is( - loggedMessages[0].message, - `Setting tools: ${url} based on workflow input.`, - ); - }, -); + t.is(result, url); + t.is(loggedMessages.length, 1); + t.is( + loggedMessages[0].message, + `Setting tools: ${url} based on workflow input.`, + ); +}); -test( - "resolveToolsInput returns repository property with 'latest' value", - (t) => { - const loggedMessages: LoggedMessage[] = []; - const logger = getRecordingLogger(loggedMessages); +test("resolveToolsInput returns repository property with 'latest' value", (t) => { + const loggedMessages: LoggedMessage[] = []; + const logger = getRecordingLogger(loggedMessages); - const repositoryProperties: RepositoryProperties = { - [RepositoryPropertyName.TOOLS]: "latest", - }; - const result = resolveToolsInput(undefined, repositoryProperties, logger); + const repositoryProperties: RepositoryProperties = { + [RepositoryPropertyName.TOOLS]: "latest", + }; + const result = resolveToolsInput(undefined, repositoryProperties, logger); - t.is(result, "latest"); - t.is( - loggedMessages[0].message, - "Setting tools: latest based on the 'github-codeql-tools' repository property.", - ); - }, -); + t.is(result, "latest"); + t.is( + loggedMessages[0].message, + "Setting tools: latest based on the 'github-codeql-tools' repository property.", + ); +}); -test( - "resolveToolsInput returns repository property with specific version", - (t) => { - const loggedMessages: LoggedMessage[] = []; - const logger = getRecordingLogger(loggedMessages); +test("resolveToolsInput returns repository property with specific version", (t) => { + const loggedMessages: LoggedMessage[] = []; + const logger = getRecordingLogger(loggedMessages); - const repositoryProperties: RepositoryProperties = { - [RepositoryPropertyName.TOOLS]: "2.16.1", - }; - const result = resolveToolsInput(undefined, repositoryProperties, logger); + const repositoryProperties: RepositoryProperties = { + [RepositoryPropertyName.TOOLS]: "2.16.1", + }; + const result = resolveToolsInput(undefined, repositoryProperties, logger); - t.is(result, "2.16.1"); - t.is( - loggedMessages[0].message, - "Setting tools: 2.16.1 based on the 'github-codeql-tools' repository property.", - ); - }, -); + t.is(result, "2.16.1"); + t.is( + loggedMessages[0].message, + "Setting tools: 2.16.1 based on the 'github-codeql-tools' repository property.", + ); +}); -test( - "resolveToolsInput returns undefined when repository property is undefined", - (t) => { - const loggedMessages: LoggedMessage[] = []; - const logger = getRecordingLogger(loggedMessages); +test("resolveToolsInput returns undefined when repository property is undefined", (t) => { + const loggedMessages: LoggedMessage[] = []; + const logger = getRecordingLogger(loggedMessages); - const repositoryProperties: RepositoryProperties = { - [RepositoryPropertyName.TOOLS]: undefined, - }; - const result = resolveToolsInput(undefined, repositoryProperties, logger); - - t.is(result, undefined); - t.is(loggedMessages.length, 0); - }, -); + const repositoryProperties: RepositoryProperties = { + [RepositoryPropertyName.TOOLS]: undefined, + }; + const result = resolveToolsInput(undefined, repositoryProperties, logger); + t.is(result, undefined); + t.is(loggedMessages.length, 0); +}); diff --git a/src/resolve-tools-input.ts b/src/resolve-tools-input.ts index f9aca4fda..beff11a7c 100644 --- a/src/resolve-tools-input.ts +++ b/src/resolve-tools-input.ts @@ -20,7 +20,9 @@ export function resolveToolsInput( logger: Logger, ): string | undefined { if (toolsWorkflowInput) { - logger.info(`Setting tools: ${toolsWorkflowInput} based on workflow input.`); + logger.info( + `Setting tools: ${toolsWorkflowInput} based on workflow input.`, + ); return toolsWorkflowInput; }