github/codeql-action
1
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2026-10-03 17:41:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't store error message in StartProxyError errors

Browse Source
This commit is contained in:
Michael B. Gale
2026-02-02 17:26:37 +00:00
parent 832a783bd4
commit 42fb267c1c
3 changed files with 60 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/start-proxy.test.ts
View File

@@ -22,10 +22,14 @@ import {
setupTests(test);
test("sendFailedStatusReport - does not report arbitrary error messages", async (t) => {
test("sendFailedStatusReport - does not report messages from arbitrary error types", async (t) => {
const loggedMessages = [];
const logger = getRecordingLogger(loggedMessages);
const error = new Error(startProxyExports.StartProxyErrorType.DownloadFailed);
const error = new Error(
startProxyExports.getStartProxyErrorMessage(
startProxyExports.StartProxyErrorType.DownloadFailed,
),
);
const now = new Date();
// Override core.setFailed to avoid it setting the program's exit code
@@ -374,11 +378,18 @@ test("getSafeErrorMessage - returns actual message for `StartProxyError`", (t) =
const error = new startProxyExports.StartProxyError(
startProxyExports.StartProxyErrorType.DownloadFailed,
);
t.is(startProxyExports.getSafeErrorMessage(error), error.message);
t.is(
startProxyExports.getSafeErrorMessage(error),
startProxyExports.getStartProxyErrorMessage(error.errorType),
);
});
test("getSafeErrorMessage - does not return message for arbitrary errors", (t) => {
const error = new Error(startProxyExports.StartProxyErrorType.DownloadFailed);
const error = new Error(
startProxyExports.getStartProxyErrorMessage(
startProxyExports.StartProxyErrorType.DownloadFailed,
),
);
const message = startProxyExports.getSafeErrorMessage(error);