From 912708411bb42510370cb242ff6dd011cda4af78 Mon Sep 17 00:00:00 2001 From: Henry Mercer Date: Fri, 16 Oct 2026 15:07:36 +0100 Subject: [PATCH] Remove redundant empty-list check Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --- lib/entry-points.js | 6 +----- src/setup-codeql.ts | 8 +------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/lib/entry-points.js b/lib/entry-points.js index 2982b8495..b6728397f 100644 --- a/lib/entry-points.js +++ b/lib/entry-points.js @@ -176293,13 +176293,9 @@ async function getEnabledVersionsWithOverlayBaseDatabases(defaultCliVersion, raw return []; } const cachedVersionsSet = new Set(cachedVersions); - const overlayVersions = defaultCliVersion.enabledVersions.filter( + return defaultCliVersion.enabledVersions.filter( (v) => cachedVersionsSet.has(v.cliVersion) ); - if (overlayVersions.length === 0) { - return []; - } - return overlayVersions; } async function resolveDefaultCliVersion(defaultCliVersion, rawLanguages, useOverlayAwareDefaultCliVersion, variant, logger2) { if (!useOverlayAwareDefaultCliVersion || variant !== "GitHub.com" /* DOTCOM */ && variant !== "GitHub Enterprise Cloud with data residency" /* GHEC_DR */ || defaultCliVersion.enabledVersions.length === 1 || !isAnalyzingPullRequest()) { diff --git a/src/setup-codeql.ts b/src/setup-codeql.ts index 6932478bc..cece0dcd2 100644 --- a/src/setup-codeql.ts +++ b/src/setup-codeql.ts @@ -213,15 +213,9 @@ export async function getEnabledVersionsWithOverlayBaseDatabases( } const cachedVersionsSet = new Set(cachedVersions); - const overlayVersions = defaultCliVersion.enabledVersions.filter((v) => + return defaultCliVersion.enabledVersions.filter((v) => cachedVersionsSet.has(v.cliVersion), ); - - if (overlayVersions.length === 0) { - return []; - } - - return overlayVersions; } /**