diff --git a/.github/workflows/__diagnostics-without-db.yml b/.github/workflows/__diagnostics-without-db.yml index 71c597d74..2122225a2 100644 --- a/.github/workflows/__diagnostics-without-db.yml +++ b/.github/workflows/__diagnostics-without-db.yml @@ -79,7 +79,9 @@ jobs: - name: Analyze uses: ./analyze # In a real workflow, this step wouldn't run. Since we used `continue-on-error` - # above, we manually disable it with an `if` condition. + # above, we manually disable it with an `if` condition. Having this step is required + # for the init post-action because it checks the workflow definition for e.g. the + # `category` input. Without this step, that part of the init post-action would fail. if: false with: category: '/test-codeql-version:${{ matrix.version }}' diff --git a/.github/workflows/__submit-sarif-failure.yml b/.github/workflows/__submit-sarif-failure.yml index 099e93001..36f7be4eb 100644 --- a/.github/workflows/__submit-sarif-failure.yml +++ b/.github/workflows/__submit-sarif-failure.yml @@ -71,7 +71,9 @@ jobs: run: exit 1 - uses: ./analyze # In a real workflow, this step wouldn't run. Since we used `continue-on-error` - # above, we manually disable it with an `if` condition. + # above, we manually disable it with an `if` condition. Having this step is required + # for the init post-action because it checks the workflow definition for e.g. the + # `category` input. Without this step, that part of the init post-action would fail. if: false with: category: '/test-codeql-version:${{ matrix.version }}' diff --git a/pr-checks/checks/diagnostics-without-db.yml b/pr-checks/checks/diagnostics-without-db.yml index e346a1cab..d15878cfc 100644 --- a/pr-checks/checks/diagnostics-without-db.yml +++ b/pr-checks/checks/diagnostics-without-db.yml @@ -31,7 +31,9 @@ steps: - name: Analyze uses: ./analyze # In a real workflow, this step wouldn't run. Since we used `continue-on-error` - # above, we manually disable it with an `if` condition. + # above, we manually disable it with an `if` condition. Having this step is required + # for the init post-action because it checks the workflow definition for e.g. the + # `category` input. Without this step, that part of the init post-action would fail. if: false with: category: "/test-codeql-version:${{ matrix.version }}" diff --git a/pr-checks/checks/submit-sarif-failure.yml b/pr-checks/checks/submit-sarif-failure.yml index c33e1322f..ea156ca93 100644 --- a/pr-checks/checks/submit-sarif-failure.yml +++ b/pr-checks/checks/submit-sarif-failure.yml @@ -35,7 +35,9 @@ steps: run: exit 1 - uses: ./analyze # In a real workflow, this step wouldn't run. Since we used `continue-on-error` - # above, we manually disable it with an `if` condition. + # above, we manually disable it with an `if` condition. Having this step is required + # for the init post-action because it checks the workflow definition for e.g. the + # `category` input. Without this step, that part of the init post-action would fail. if: false with: category: "/test-codeql-version:${{ matrix.version }}"