github/codeql-action
1
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2026-11-10 14:56:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Turn all feature flags on

Browse Source
This commit is contained in:
Angela P Wen
2022-09-21 09:48:33 -07:00
parent 038242a7f0
commit bc0afcb969
3 changed files with 44 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/feature-flags.ts
View File

@@ -33,26 +33,29 @@ export class GitHubFeatureFlags implements FeatureFlags {
) {}
async getValue(flag: FeatureFlag): Promise<boolean> {
// Bypassing the toolcache is disabled in test mode.
if (flag === FeatureFlag.BypassToolcacheEnabled && util.isInTestMode()) {
return false;
}
// Always return true for purposes of investigation in this PR.
return true;
const response = await this.getApiResponse();
if (response === undefined) {
this.logger.debug(
`No feature flags API response for ${flag}, considering it disabled.`
);
return false;
}
const flagValue = response[flag];
if (flagValue === undefined) {
this.logger.debug(
`Feature flag '${flag}' undefined in API response, considering it disabled.`
);
return false;
}
return flagValue;
// // Bypassing the toolcache is disabled in test mode.
// if (flag === FeatureFlag.BypassToolcacheEnabled && util.isInTestMode()) {
// return false;
// }
// const response = await this.getApiResponse();
// if (response === undefined) {
// this.logger.debug(
// `No feature flags API response for ${flag}, considering it disabled.`
// );
// return false;
// }
// const flagValue = response[flag];
// if (flagValue === undefined) {
// this.logger.debug(
// `Feature flag '${flag}' undefined in API response, considering it disabled.`
// );
// return false;
// }
// return flagValue;
}
private async getApiResponse(): Promise<FeatureFlagsApiResponse> {