github/codeql-action
1
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2026-10-03 17:41:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add random suffix when writing diagnostics to avoid filename collisions

Browse Source
This commit is contained in:
Henry Mercer
2026-04-28 11:29:32 +01:00
parent 19b3a84f58
commit cdb655d6d4
7 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/analyze-action.js generated
View File

@@ -107892,10 +107892,11 @@ function writeDiagnostic(config, language, diagnostic) {
); );
try { try {
(0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true }); (0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true });
const uniqueSuffix = Math.floor(Math.random() * 4294967296).toString(16).padStart(8, "0");
const jsonPath = import_path.default.resolve( const jsonPath = import_path.default.resolve(
diagnosticsPath, diagnosticsPath,
// Remove colons from the timestamp as these are not allowed in Windows filenames. // Remove colons from the timestamp as these are not allowed in Windows filenames.
`codeql-action-${diagnostic.timestamp.replaceAll(":", "")}.json` `codeql-action-${diagnostic.timestamp.replaceAll(":", "")}-${uniqueSuffix}.json`
); );
(0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic)); (0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic));
} catch (err) { } catch (err) {

3
lib/init-action-post.js generated
View File

@@ -165811,10 +165811,11 @@ function writeDiagnostic(config, language, diagnostic) {
); );
try { try {
(0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true }); (0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true });
const uniqueSuffix = Math.floor(Math.random() * 4294967296).toString(16).padStart(8, "0");
const jsonPath = import_path.default.resolve( const jsonPath = import_path.default.resolve(
diagnosticsPath, diagnosticsPath,
// Remove colons from the timestamp as these are not allowed in Windows filenames. // Remove colons from the timestamp as these are not allowed in Windows filenames.
`codeql-action-${diagnostic.timestamp.replaceAll(":", "")}.json` `codeql-action-${diagnostic.timestamp.replaceAll(":", "")}-${uniqueSuffix}.json`
); );
(0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic)); (0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic));
} catch (err) { } catch (err) {

3
lib/init-action.js generated
View File

@@ -105397,10 +105397,11 @@ function writeDiagnostic(config, language, diagnostic) {
); );
try { try {
(0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true }); (0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true });
const uniqueSuffix = Math.floor(Math.random() * 4294967296).toString(16).padStart(8, "0");
const jsonPath = import_path.default.resolve( const jsonPath = import_path.default.resolve(
diagnosticsPath, diagnosticsPath,
// Remove colons from the timestamp as these are not allowed in Windows filenames. // Remove colons from the timestamp as these are not allowed in Windows filenames.
`codeql-action-${diagnostic.timestamp.replaceAll(":", "")}.json` `codeql-action-${diagnostic.timestamp.replaceAll(":", "")}-${uniqueSuffix}.json`
); );
(0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic)); (0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic));
} catch (err) { } catch (err) {

3
lib/setup-codeql-action.js generated
View File

@@ -105467,10 +105467,11 @@ function writeDiagnostic(config, language, diagnostic) {
); );
try { try {
(0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true }); (0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true });
const uniqueSuffix = Math.floor(Math.random() * 4294967296).toString(16).padStart(8, "0");
const jsonPath = import_path.default.resolve( const jsonPath = import_path.default.resolve(
diagnosticsPath, diagnosticsPath,
// Remove colons from the timestamp as these are not allowed in Windows filenames. // Remove colons from the timestamp as these are not allowed in Windows filenames.
`codeql-action-${diagnostic.timestamp.replaceAll(":", "")}.json` `codeql-action-${diagnostic.timestamp.replaceAll(":", "")}-${uniqueSuffix}.json`
); );
(0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic)); (0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic));
} catch (err) { } catch (err) {

3
lib/upload-lib.js generated
View File

@@ -107502,10 +107502,11 @@ function writeDiagnostic(config, language, diagnostic) {
); );
try { try {
(0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true }); (0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true });
const uniqueSuffix = Math.floor(Math.random() * 4294967296).toString(16).padStart(8, "0");
const jsonPath = import_path.default.resolve( const jsonPath = import_path.default.resolve(
diagnosticsPath, diagnosticsPath,
// Remove colons from the timestamp as these are not allowed in Windows filenames. // Remove colons from the timestamp as these are not allowed in Windows filenames.
`codeql-action-${diagnostic.timestamp.replaceAll(":", "")}.json` `codeql-action-${diagnostic.timestamp.replaceAll(":", "")}-${uniqueSuffix}.json`
); );
(0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic)); (0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic));
} catch (err) { } catch (err) {

3
lib/upload-sarif-action.js generated
View File

@@ -108258,10 +108258,11 @@ function writeDiagnostic(config, language, diagnostic) {
); );
try { try {
(0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true }); (0, import_fs.mkdirSync)(diagnosticsPath, { recursive: true });
const uniqueSuffix = Math.floor(Math.random() * 4294967296).toString(16).padStart(8, "0");
const jsonPath = import_path.default.resolve( const jsonPath = import_path.default.resolve(
diagnosticsPath, diagnosticsPath,
// Remove colons from the timestamp as these are not allowed in Windows filenames. // Remove colons from the timestamp as these are not allowed in Windows filenames.
`codeql-action-${diagnostic.timestamp.replaceAll(":", "")}.json` `codeql-action-${diagnostic.timestamp.replaceAll(":", "")}-${uniqueSuffix}.json`
); );
(0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic)); (0, import_fs.writeFileSync)(jsonPath, JSON.stringify(diagnostic));
} catch (err) { } catch (err) {

8
src/diagnostics.ts
View File

@@ -167,10 +167,16 @@ function writeDiagnostic(
// Create the directory if it doesn't exist yet. // Create the directory if it doesn't exist yet.
mkdirSync(diagnosticsPath, { recursive: true }); mkdirSync(diagnosticsPath, { recursive: true });
// Include a random suffix to avoid filename collisions between diagnostics
// produced within the same millisecond. This doesn't need to be
// cryptographically secure, so `Math.random` is fine.
const uniqueSuffix = Math.floor(Math.random() * 0x100000000)
.toString(16)
.padStart(8, "0");
const jsonPath = path.resolve( const jsonPath = path.resolve(
diagnosticsPath, diagnosticsPath,
// Remove colons from the timestamp as these are not allowed in Windows filenames. // Remove colons from the timestamp as these are not allowed in Windows filenames.
`codeql-action-${diagnostic.timestamp.replaceAll(":", "")}.json`, `codeql-action-${diagnostic.timestamp.replaceAll(":", "")}-${uniqueSuffix}.json`,
); );
writeFileSync(jsonPath, JSON.stringify(diagnostic)); writeFileSync(jsonPath, JSON.stringify(diagnostic));