From d1a7580bd31a2da8ab72105a65ba08108e7b29e9 Mon Sep 17 00:00:00 2001 From: "Michael B. Gale" Date: Wed, 11 Mar 2026 12:29:36 +0000 Subject: [PATCH] Verify PR checks in a different job, with newer Node --- .github/workflows/pr-checks.yml | 43 ++++++++++++++++++++++++++------- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/.github/workflows/pr-checks.yml b/.github/workflows/pr-checks.yml index 77a544cfa..501878d22 100644 --- a/.github/workflows/pr-checks.yml +++ b/.github/workflows/pr-checks.yml @@ -52,19 +52,10 @@ jobs: - name: Verify compiled JS up to date run: .github/workflows/script/check-js.sh - - name: Verify PR checks up to date - if: always() - run: .github/workflows/script/verify-pr-checks.sh - - name: Run unit tests if: always() run: npm test - - name: Run pr-checks tests - if: always() - working-directory: pr-checks - run: npm ci && npx tsx --test - - name: Lint if: always() && matrix.os != 'windows-latest' run: npm run lint-ci @@ -76,6 +67,40 @@ jobs: sarif_file: eslint.sarif category: eslint + # Verifying the PR checks are up-to-date requires Node 24. The PR checks are not dependent + # on the main codebase and therefore do not need to be run as part of the same matrix that + # we use for the `unit-tests` job. + verify-pr-checks: + name: Verify PR checks + if: github.triggering_actor != 'dependabot[bot]' + permissions: + contents: read + runs-on: ubuntu-slim + timeout-minutes: 10 + + steps: + - name: Prepare git (Windows) + if: runner.os == 'Windows' + run: git config --global core.autocrlf false + + - name: Checkout repository + uses: actions/checkout@v6 + + - name: Set up Node.js + uses: actions/setup-node@v6 + with: + node-version: 24 + cache: 'npm' + + - name: Verify PR checks up to date + if: always() + run: .github/workflows/script/verify-pr-checks.sh + + - name: Run pr-checks tests + if: always() + working-directory: pr-checks + run: npm ci && npx tsx --test + check-node-version: if: github.triggering_actor != 'dependabot[bot]' name: Check Action Node versions