Commit Graph

441 Commits

Author SHA1 Message Date
Michael B. Gale
26c6f91e6b Throw if aborted config functions are called incorrectly 2026-10-12 22:42:38 +01:00
Michael B. Gale
be78e02f2d Fix comment 2026-10-12 22:39:34 +01:00
Michael B. Gale
5136039854 Store partial configuration when init is aborted 2026-10-12 13:07:36 +01:00
Michael B. Gale
19445ddfed Reduce Config requirements for tryUploadSarifIfRunFailed 2026-10-12 13:07:13 +01:00
Michael B. Gale
d6196d8703 Rename exportVariable wrapper to exportEnvVar 2026-10-08 20:06:51 +01:00
Michael B. Gale
1728f0c676 Add wrapper around core.exportVariable 2026-10-07 20:12:00 +01:00
Henry Mercer
e0b8480262 Parse the config input in init without the parseConfigInput wrapper
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-05 14:24:01 +01:00
Henry Mercer
a4a04dc476 Explain that the config input is written to disk without merging
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-05 14:24:01 +01:00
Henry Mercer
113b18e688 Parse the config input once
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-02 14:42:42 +01:00
Michael B. Gale
29b01b6799 Point at Dependabot groups docs in version mismatch error 2026-09-25 15:59:36 +01:00
Henry Mercer
ceb85f25b5 Distinguish GitHub-hosted runners from ones that look hosted
`isHostedRunner` infers hostedness from the runner name and the toolcache path, so it also matches self-hosted runners that are configured to resemble hosted ones. Rename it to `looksLikeHostedRunner` so callers can see they are getting a heuristic, and add `isGitHubHostedRunner`, which reads the `RUNNER_ENVIRONMENT` value the Actions service reports. The existing callers keep the heuristic, so there is no behaviour change.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-04 10:12:09 +01:00
Henry Mercer
1aef003397 Address review feedback on overlay disk flags
Document each minimum disk feature flag individually and replace the tuple list with an explicit feature-to-threshold mapping.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-08-18 12:09:33 +01:00
Henry Mercer
794f5bc385 Fix the memory check debug message at equality
The comparison accepts exactly the minimum, so say "at or above", to
match the wording of the disk space check.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-08-06 16:48:44 +01:00
Henry Mercer
54109818e0 Address review feedback on the disk space check
Say "at or above" in the debug message logged when the check passes,
since the comparison accepts exactly the minimum.

Check each feature flag against the threshold its name declares, rather
than only exercising a few of them, so that a mistake in one of the
mappings cannot go unnoticed. Both sides of the boundary are needed to
pin a threshold down: a mapping to a lower value would still pass the
case at the limit, and one to a higher value would still fail the case
below it.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-08-06 16:41:48 +01:00
Henry Mercer
6117bb503a Derive overlay minimum disk space from feature flags
Overlay analysis required 20 GB of available disk space, lowered to
14 GB when overlay_analysis_resource_checks_v2 was enabled. That gave
us a single step to roll out, and any further reduction needed another
flag and another release.

Determine the threshold from the new overlay_analysis_min_disk_N_gb
flags instead, taking the lowest one that is enabled so that a lower
limit can be rolled out to a subset of repositories without first
disabling the flag above it. When none are enabled, the 14 GB limit
now applies unconditionally, replacing the 20 GB default.

Thresholds remain in decimal MB, matching the bytes-per-MB convention
the disk check already used, so the effective byte values are unchanged
from the previous 14 GB path. Also log the available and required space
at debug level when the check passes, so that run logs show which
threshold took effect.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-08-06 16:38:33 +01:00
Michael B. Gale
1b0d2714d6 Merge pull request #4036 from github/henrymercer/remove-legacy-diagnostics
Remove obsolete CodeQL setup diagnostics
2026-07-22 16:57:43 +00:00
Henry Mercer
14e8bf9e67 Remove Git version diagnostic
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-07-20 18:55:24 +01:00
Michael B. Gale
da21ad6a71 Remove NewRemoteFileAddresses FF and default to its behaviour 2026-07-20 11:22:34 +01:00
Michael B. Gale
247ce88c8f Gate changes behind new format FF 2026-07-15 16:14:55 +01:00
Michael B. Gale
decb87044a Rename helper functions 2026-07-15 16:13:02 +01:00
Michael B. Gale
abce6483ea Fix typo in comment 2026-07-15 16:11:50 +01:00
Michael B. Gale
23339952d6 Add expliciit prefix for remote file addresses 2026-07-15 15:59:23 +01:00
Michael B. Gale
001d4ae610 Move the local path prefix into a constant 2026-07-15 15:56:52 +01:00
Michael B. Gale
6d3bde3729 Split up and document isLocal 2026-07-15 14:32:14 +01:00
Michael B. Gale
9c0c11a49e Add tests for loadUserConfig 2026-07-15 14:31:39 +01:00
Michael B. Gale
6973946465 Check file on disk and mutated inputs 2026-07-09 23:09:14 +01:00
Michael B. Gale
6829d6ce38 Remove obsolete JSDoc parameter for loadUserConfig 2026-07-09 23:02:58 +01:00
Michael B. Gale
d2472aa525 Merge remote-tracking branch 'origin/main' into mbg/config/merge 2026-07-09 23:01:05 +01:00
Michael B. Gale
06898d7b8b Rename mergeUserConfigs 2026-07-08 17:46:02 +01:00
Michael B. Gale
7ccd988125 Merge branch 'main' into mbg/config/merge 2026-07-08 17:31:19 +01:00
Michael B. Gale
8e22350a7e Thread ActionState to initConfig 2026-07-06 15:46:35 +01:00
Michael B. Gale
73f4741039 Refactor pack registry code out of config-utils 2026-07-06 15:24:50 +01:00
Michael B. Gale
5094019011 Refactor Config type out of config-utils 2026-07-06 15:14:11 +01:00
Michael B. Gale
8476401b09 Make lazy FF check less ambiguous 2026-07-06 14:45:41 +01:00
Michael B. Gale
4509fb3c4b Fix JSDoc for determineUserConfig 2026-07-06 14:43:49 +01:00
Michael B. Gale
d149f93d92 Return mergedConfig instead of loading it again 2026-07-06 13:50:39 +01:00
Michael B. Gale
3707b44eaa Document that inputs might be mutated 2026-07-06 13:50:39 +01:00
Michael B. Gale
42c0c6aedd Allow merging Default Setup config with config file 2026-07-06 13:50:39 +01:00
Michael B. Gale
31577749b3 Give determineUserConfig access to the environment 2026-07-06 13:50:39 +01:00
Michael B. Gale
0188f395e2 Add unit tests for existing behaviour of determineUserConfig 2026-07-06 13:50:38 +01:00
Michael B. Gale
6860cc1f50 Move validateConfig FF query 2026-07-06 13:50:38 +01:00
Michael B. Gale
53a488ce2e Add JSDoc for loadUserConfig 2026-07-06 13:50:38 +01:00
Michael B. Gale
cd604f831b Refactor determineUserConfig out of initConfig 2026-07-06 13:50:37 +01:00
Michael B. Gale
708e106533 Index ActionState over the types of state used 2026-06-30 17:19:20 +01:00
Michael B. Gale
f86aa521ce Use ActionState for getRemoteConfig 2026-06-30 13:03:00 +01:00
Michael B. Gale
07b6b1eac5 Move getRemoteConfig to config/file.ts 2026-06-23 16:49:03 +01:00
Henry Mercer
72b0f9fed4 Clean up codeql.resolveLanguages
Only the betterjson option is now used, so remove the old version.
2026-06-05 12:50:57 +01:00
Henry Mercer
524532393a Disable missing diff-ranges fallback when overlay enabled manually 2026-06-01 15:34:08 +01:00
Sam Robson
9d7243005b Merge remote-tracking branch 'origin/main' into sam-robson/overlay-fallback
* origin/main: (40 commits)
  Bump the npm-minor group across 1 directory with 3 updates
  Bump actions/create-github-app-token
  Nit: Tweak JSDoc for `getRawLanguagesNoAutodetect`
  Enable only `code-scanning`
  Use overlay-aware version for code scanning exclusively
  Add changelog entry
  Rebuild
  Bump five transitive dependencies
  Throw error if multiple analysis kinds are specified
  Bump fast-xml-builder from 1.1.5 to 1.2.0
  Improve tests
  Improve error message
  Remove dead code
  Remove `makeOverlayMatchFeatures` indirection
  Add JSDoc for `getRawLanguagesNoAutodetect`
  Enable overlay-aware version selection in `setup-codeql`
  Minor: Introduce constant to avoid duplication
  Improve changelog note
  Rebuild
  Update changelog and version after v4.35.4
  ...

# Conflicts:
#	lib/init-action.js
#	src/diff-informed-analysis-utils.test.ts
2026-05-14 13:39:44 +01:00
Henry Mercer
8d217609b0 Nit: Tweak JSDoc for getRawLanguagesNoAutodetect 2026-05-12 16:21:44 +01:00