Commit Graph

4227 Commits

Author SHA1 Message Date
Michael B. Gale
78ebd22fd6 Make diagnostics less dependent on global state
Add limited test coverage
2026-10-16 17:18:10 +01:00
Michael B. Gale
39f74e9837 Write diagnostics to temporary location when database isn't ready 2026-10-16 17:18:09 +01:00
Michael B. Gale
11fd255a0b Refactor writeDiagnosticFile out of writeDiagnostic 2026-10-16 17:18:08 +01:00
Michael B. Gale
d6b8ed80f2 Ensure that rootDirectory is suitable for sarifFile in uploadSarifArtifact 2026-10-16 17:02:02 +01:00
Michael B. Gale
3a61940e40 Improve logging in uploadSarifArtifact 2026-10-16 17:02:02 +01:00
Michael B. Gale
850cc877c3 Upload failed SARIF as workflow artifact in test mode 2026-10-16 17:01:24 +01:00
Michael B. Gale
68eb797e87 Skip waiting for SARIF if nothing was uploaded 2026-10-16 16:54:37 +01:00
Michael B. Gale
2765b8f6f9 Propagate Config to combineSarifFilesUsingCLI 2026-10-16 16:54:37 +01:00
Michael B. Gale
b1c5d475ab Add and use shouldSkipGenerateFailedSarif 2026-10-16 16:54:37 +01:00
Michael B. Gale
e180f803c5 Allow to explicitly not skip the SARIF upload 2026-10-16 16:54:36 +01:00
Michael B. Gale
bf0e2ed66e Log when we didn't get a normal configuration file 2026-10-16 16:54:36 +01:00
Henry Mercer
ae098fa9fe Merge pull request #4242 from github/henrymercer/graduate-toolcache-cleanup
Enable cleaning up toolcache bundles by default
2026-10-16 12:43:00 +00:00
Michael B. Gale
0a458f10ac Merge pull request #4230 from github/mbg/auth/allow-unauthed
Make `auth` in `GitHubApiDetails` optional
2026-10-16 11:05:53 +00:00
Henry Mercer
1ec6b03cf4 Enable toolcache bundle cleanup by default
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9bf883d4-ecd7-4428-970f-86895f760571
2026-10-15 14:54:30 +01:00
Michael B. Gale
8dec0b9f88 Rename path to result in tests 2026-10-15 11:03:10 +01:00
Michael B. Gale
4eabea6b5e Merge remote-tracking branch 'origin/main' into mbg/start-proxy/report-version 2026-10-15 10:31:39 +01:00
Michael B. Gale
c1641847bb Remove explicit authorization header from uploadBundledDatabase 2026-10-14 20:03:19 +01:00
Michael B. Gale
047c751d92 Add a test for uploadBundledDatabase 2026-10-14 20:02:27 +01:00
Michael B. Gale
f6e8dce502 Pass apiDetails to getApiClient in uploadBundledDatabase 2026-10-14 18:28:21 +01:00
Michael B. Gale
a08b587b61 Allow getApiClient to accept GitHubApiDetails 2026-10-14 18:27:15 +01:00
Michael B. Gale
bfe264b559 Add very basic getApiClientWithExternalAuth test 2026-10-14 18:19:52 +01:00
Michael B. Gale
f9b4185b99 Check token value in uploadBundledDatabase 2026-10-14 18:19:52 +01:00
Michael B. Gale
66c96fdc35 Check auth value in getAuthorizationHeaderFor
Also add some tests for it
2026-10-14 18:19:52 +01:00
Michael B. Gale
1d30a842cd Guard against blank auth value
This shouldn't be possible, but was previously handled by the library
2026-10-14 18:19:51 +01:00
Michael B. Gale
1b0a617641 Make externalRepoAuth check more consistent 2026-10-14 18:19:51 +01:00
Michael B. Gale
96501a33ac Use getCurrentInstance() 2026-10-14 18:19:51 +01:00
Michael B. Gale
a2438139ce Make auth property on GitHubApiDetails optional 2026-10-14 18:19:50 +01:00
Michael B. Gale
e0625309c3 Move GitHubApiDetails to github.ts 2026-10-14 18:19:50 +01:00
Michael B. Gale
61bfcffab9 Add functions to get the current and dotcom instance 2026-10-14 18:19:50 +01:00
Michael B. Gale
102e46e9d1 Move some definitions out of util.ts into a new github.ts module 2026-10-14 18:19:46 +01:00
Michael B. Gale
0735d7910f Improve GitHubApiDetails types and documentation 2026-10-14 18:14:48 +01:00
Michael B. Gale
2a3e7563aa Merge pull request #4148 from github/mbg/improve-checkout-path
Validate `checkout_path` input in `analyze` action
2026-10-14 14:52:50 +00:00
Michael B. Gale
f460dc7f72 Merge pull request #4206 from github/mbg/set-restore-keys
Include primary cache keys as restore key
2026-10-14 14:45:03 +00:00
Michael B. Gale
28d5dd9818 Revert "Allow logging functions to accept string[] directly"
This reverts commit 909fda1468.
2026-10-14 15:07:40 +01:00
Michael B. Gale
962aaad938 Rename proxyBin to proxyDir 2026-10-14 13:58:37 +01:00
Michael B. Gale
71ad3a794a Fix typo in log message 2026-10-14 13:57:43 +01:00
Michael B. Gale
9da96258e6 Merge remote-tracking branch 'origin/main' into mbg/start-proxy/deprecate-fallback 2026-10-14 13:56:57 +01:00
Michael B. Gale
4f747696ca Merge branch 'main' into mbg/improve-checkout-path 2026-10-14 10:57:57 +01:00
Michael B. Gale
15800587e3 Add unit test for sendSuccessStatusReport 2026-10-14 10:31:29 +01:00
Michael B. Gale
6aee1f8ef9 Sort registry_types in status report 2026-10-14 10:30:14 +01:00
Michael B. Gale
43db2c064c Include proxy version in telemetry 2026-10-13 19:12:13 +01:00
Michael B. Gale
6308e366c9 Return release version from getProxyBinaryPath 2026-10-13 19:06:14 +01:00
Michael B. Gale
aa80ca0686 Move start-proxy status report handling into its own file 2026-10-13 18:59:11 +01:00
Michael B. Gale
b67b5abe29 Use parseRepositoryNwo in getCodeQLAssetDownloadURL 2026-10-13 12:13:59 +01:00
Michael B. Gale
9645acc2ff Revert config === undefined condition 2026-10-12 22:54:47 +01:00
Michael B. Gale
6a9f7e7fc3 Log if returning early from recordOverlayStatus due to no languages 2026-10-12 22:50:11 +01:00
Michael B. Gale
67f44bc916 Use Logger for printDebugLogs and log when returning early 2026-10-12 22:48:21 +01:00
Michael B. Gale
26c6f91e6b Throw if aborted config functions are called incorrectly 2026-10-12 22:42:38 +01:00
Michael B. Gale
e3aeabd8f1 Fix example in comment 2026-10-12 22:40:25 +01:00
Michael B. Gale
be78e02f2d Fix comment 2026-10-12 22:39:34 +01:00