Resolve the overlap with the separately shipped promotion of the overlay resource checks while preserving the feature-flagged minimum disk thresholds.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Say "at or above" in the debug message logged when the check passes,
since the comparison accepts exactly the minimum.
Check each feature flag against the threshold its name declares, rather
than only exercising a few of them, so that a mistake in one of the
mappings cannot go unnoticed. Both sides of the boundary are needed to
pin a threshold down: a mapping to a lower value would still pass the
case at the limit, and one to a higher value would still fail the case
below it.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Overlay analysis required 20 GB of available disk space, lowered to
14 GB when overlay_analysis_resource_checks_v2 was enabled. That gave
us a single step to roll out, and any further reduction needed another
flag and another release.
Determine the threshold from the new overlay_analysis_min_disk_N_gb
flags instead, taking the lowest one that is enabled so that a lower
limit can be rolled out to a subset of repositories without first
disabling the flag above it. When none are enabled, the 14 GB limit
now applies unconditionally, replacing the 20 GB default.
Thresholds remain in decimal MB, matching the bytes-per-MB convention
the disk check already used, so the effective byte values are unchanged
from the previous 14 GB path. Also log the available and required space
at debug level when the check passes, so that run logs show which
threshold took effect.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* origin/main: (40 commits)
Bump the npm-minor group across 1 directory with 3 updates
Bump actions/create-github-app-token
Nit: Tweak JSDoc for `getRawLanguagesNoAutodetect`
Enable only `code-scanning`
Use overlay-aware version for code scanning exclusively
Add changelog entry
Rebuild
Bump five transitive dependencies
Throw error if multiple analysis kinds are specified
Bump fast-xml-builder from 1.1.5 to 1.2.0
Improve tests
Improve error message
Remove dead code
Remove `makeOverlayMatchFeatures` indirection
Add JSDoc for `getRawLanguagesNoAutodetect`
Enable overlay-aware version selection in `setup-codeql`
Minor: Introduce constant to avoid duplication
Improve changelog note
Rebuild
Update changelog and version after v4.35.4
...
# Conflicts:
# lib/init-action.js
# src/diff-informed-analysis-utils.test.ts
While we want the CodeQL Action to work with third-party language support, having a list of all built-in languages can help us create better type-level checks to ensure that we don't miss things that we want to customize for each of our built-in languages.
