github/codeql-action
1
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2026-11-10 14:56:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make input-validation assertions more granular

Browse Source
This commit is contained in:
Mario Campos
2026-10-29 10:13:06 -05:00
parent 87cac24cdd
commit 5bb3554330
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pr-checks/post-comment.test.ts
View File

@@ -64,14 +64,14 @@ describe("parseOptions", async () => {
await it("rejects an empty --marker", () => {
assert.throws(
() => parseOptions(withFlag("--marker", "")),
/Missing required flag --marker/,
/The value for --marker cannot be empty/,
);
});
await it("rejects a whitespace-only --marker", () => {
assert.throws(
() => parseOptions(withFlag("--marker", " \t\n")),
/Missing required flag --marker/,
/The value for --marker cannot be empty/,
);
});
});

8
pr-checks/post-comment.ts
View File

@@ -46,12 +46,16 @@ export function parseOptions(argv?: string[]): Options {
strict: true,
});
assert(values.marker?.trim(), "Missing required flag --marker.");
assert(values.marker !== undefined, "Missing required flag --marker.");
assert(
values.marker.trim() !== "",
"The value for --marker cannot be empty.",
);
const [owner, repo] = values.repository!.split("/");
return {
body: values.body!,
marker: values.marker!,
marker: values.marker,
issueId: Number(values["issue-id"]),
repository: { owner, repo },
};