github/codeql-action
1
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2026-10-30 09:37:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix mockGetReleaseByTag usage

Browse Source
This commit is contained in:
Michael B. Gale
2026-10-12 15:45:21 +01:00
parent ac44fd0901
commit a1794a03ff
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/start-proxy.test.ts
View File

@@ -729,7 +729,10 @@ function mockGetReleaseByTag(expectedTag?: string, assets?: ReleaseAssets) {
}
});
return mockGetApiClient({ repos: { getReleaseByTag } });
return {
getReleaseByTag,
getApiClient: mockGetApiClient({ repos: { getReleaseByTag } }),
};
}
function mockOfflineFeatures(tempDir: string, logger: Logger) {
@@ -833,7 +836,7 @@ test.serial(
sinon.stub(actionsUtil, "isRunningLocalAction").returns(true);
for (const assets of testAssets) {
const stub = mockGetReleaseByTag(defaults.bundleVersion, assets);
const stubs = mockGetReleaseByTag(defaults.bundleVersion, assets);
const info = await startProxyExports.getDownloadUrl(
state,
SAMPLE_DOTCOM_API_DETAILS,
@@ -848,7 +851,9 @@ test.serial(
),
);
stub.restore();
// mockGetReleaseByTag stubs the global getApiClient; since we are calling
// that in a loop, we need to manually restore it here
stubs.getApiClient.restore();
}
});
},
@@ -864,7 +869,7 @@ test.serial("getDownloadUrl returns matching release asset", async (t) => {
url: "url-we-want",
},
];
const getReleaseByTag = mockGetReleaseByTag(defaults.bundleVersion, assets);
const stubs = mockGetReleaseByTag(defaults.bundleVersion, assets);
await withTmpDir(async (tempDir) => {
state.env.set(ActionsEnvVars.RUNNER_TEMP, tempDir);
@@ -879,7 +884,7 @@ test.serial("getDownloadUrl returns matching release asset", async (t) => {
SAMPLE_DOTCOM_API_DETAILS,
);
t.is(getReleaseByTag.callCount, 1);
t.is(stubs.getReleaseByTag.callCount, 1);
t.is(info.version, defaults.cliVersion);
t.is(info.url, "url-we-want");
@@ -1036,7 +1041,7 @@ test.serial(
const logger = new RecordingLogger();
const state = initAllState({ logger });
const downloadUrl = "url-we-want";
const getApiClient = mockGetReleaseByTag(defaults.bundleVersion, [
const stubs = mockGetReleaseByTag(defaults.bundleVersion, [
{
name: startProxyExports.getProxyPackage(getTestPlatform(state)),
url: downloadUrl,
@@ -1070,7 +1075,7 @@ test.serial(
SAMPLE_DOTCOM_API_DETAILS,
);
t.is(getApiClient.callCount, 1);
t.is(stubs.getReleaseByTag.callCount, 1);
t.assert(find.calledOnce);
t.assert(getAuthorizationHeaderFor.calledOnce);