Address review comments

This commit is contained in:
Henry Mercer
2026-02-25 15:26:48 +00:00
parent 8105503f1a
commit f379c46d49
66 changed files with 182 additions and 61 deletions

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

4
.github/workflows/__ruby.yml generated vendored
View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

4
.github/workflows/__rust.yml generated vendored
View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -18,7 +18,9 @@ on:
- synchronize
- reopened
- ready_for_review
merge_group: {}
merge_group:
types:
- checks_requested
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -8,7 +8,6 @@ on:
# Run checks on reopened draft PRs to support triggering PR checks on draft PRs that were opened
# by other workflows.
types: [opened, synchronize, reopened, ready_for_review]
merge_group:
defaults:
run:

View File

@@ -8,6 +8,7 @@ on:
# by other workflows.
types: [opened, synchronize, reopened, ready_for_review]
merge_group:
types: [checks_requested]
schedule:
# Weekly on Sunday.
- cron: '30 1 * * 0'

View File

@@ -24,6 +24,7 @@ on:
- reopened
- ready_for_review
merge_group:
types: [checks_requested]
schedule:
- cron: '0 5 * * *'
workflow_dispatch:
@@ -79,7 +80,7 @@ jobs:
# On PRs, overlay analysis may change the config that is passed to the CLI.
# Therefore, we have two variants of the following test, one for PRs and one for other events.
- name: Empty file (non-PR)
if: github.event_name != 'pull_request'
if: github.event_name != 'pull_request' && github.event_name != 'merge_group'
uses: ./../action/.github/actions/check-codescanning-config
with:
expected-config-file-contents: "{}"
@@ -87,7 +88,7 @@ jobs:
tools: ${{ steps.prepare-test.outputs.tools-url }}
- name: Empty file (PR)
if: github.event_name == 'pull_request'
if: github.event_name == 'pull_request' || github.event_name == 'merge_group'
uses: ./../action/.github/actions/check-codescanning-config
with:
expected-config-file-contents: |

View File

@@ -15,6 +15,7 @@ on:
- reopened
- ready_for_review
merge_group:
types: [checks_requested]
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -14,6 +14,7 @@ on:
- reopened
- ready_for_review
merge_group:
types: [checks_requested]
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -7,6 +7,7 @@ on:
# by other workflows.
types: [opened, synchronize, reopened, ready_for_review]
merge_group:
types: [checks_requested]
workflow_dispatch:
defaults:
@@ -81,7 +82,7 @@ jobs:
category: eslint
check-node-version:
if: github.event.pull_request && github.triggering_actor != 'dependabot[bot]'
if: github.triggering_actor != 'dependabot[bot]'
name: Check Action Node versions
runs-on: ubuntu-latest
timeout-minutes: 45

View File

@@ -8,6 +8,7 @@ on:
# by other workflows.
types: [opened, synchronize, reopened, ready_for_review]
merge_group:
types: [checks_requested]
schedule:
# Weekly on Monday.
- cron: '0 0 * * 1'

View File

@@ -12,6 +12,7 @@ on:
- reopened
- ready_for_review
merge_group:
types: [checks_requested]
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -14,6 +14,7 @@ on:
- reopened
- ready_for_review
merge_group:
types: [checks_requested]
schedule:
- cron: '0 5 * * *'
workflow_dispatch:

View File

@@ -308,7 +308,9 @@ for file in sorted((this_dir / 'checks').glob('*.yml')):
'pull_request': {
'types': ["opened", "synchronize", "reopened", "ready_for_review"]
},
'merge_group': {},
'merge_group': {
'types': ['checks_requested']
},
'schedule': [{'cron': SingleQuotedScalarString('0 5 * * *')}],
'workflow_dispatch': {
'inputs': workflowInputs