Merge pull request #4176 from github/mbg/start-proxy/improve-post-githubversion-logic

Remove unnecessary check in `start-proxy-action-post`

lib/entry-points.js

@@ -146768,9 +146768,10 @@ async function getGitHubVersionFromApi(apiClient, apiDetails) {
 }
 async function getGitHubVersion() {
   if (cachedGitHubVersion === void 0) {
+    const apiDetails = getApiDetails();
     cachedGitHubVersion = await getGitHubVersionFromApi(
-      getApiClient(),
-      getApiDetails()
+      createApiClientWithDetails(apiDetails),
+      apiDetails
     );
   }
   return cachedGitHubVersion;
@@ -164199,12 +164200,6 @@ async function runWrapper9() {
       logger.info(
         "Debug mode is on. Uploading proxy log as Actions debugging artifact..."
       );
-      if (config?.gitHubVersion.type === void 0) {
-        logger.warning(
-          `Did not upload debug artifacts because cannot determine the GitHub variant running.`
-        );
-        return;
-      }
       const gitHubVersion = await getGitHubVersion();
       checkGitHubVersionInRange(gitHubVersion, logger);
       await uploadArtifacts(

src/api-client.ts

@@ -249,9 +249,10 @@ export async function getGitHubVersionFromApi(
  */
 export async function getGitHubVersion(): Promise<GitHubVersion> {
   if (cachedGitHubVersion === undefined) {
+    const apiDetails = getApiDetails();
     cachedGitHubVersion = await getGitHubVersionFromApi(
-      getApiClient(),
-      getApiDetails(),
+      createApiClientWithDetails(apiDetails),
+      apiDetails,
     );
   }
   return cachedGitHubVersion;

src/start-proxy-action-post.ts

@@ -38,12 +38,6 @@ export async function runWrapper() {
       logger.info(
         "Debug mode is on. Uploading proxy log as Actions debugging artifact...",
       );
-      if (config?.gitHubVersion.type === undefined) {
-        logger.warning(
-          `Did not upload debug artifacts because cannot determine the GitHub variant running.`,
-        );
-        return;
-      }
       const gitHubVersion = await getGitHubVersion();
       checkGitHubVersionInRange(gitHubVersion, logger);