Commit Graph

11013 Commits

Author SHA1 Message Date
Mario Campos
1a18e9047f Merge branch 'main' into mario-campos/warn-on-changelog-write 2026-10-30 09:27:10 -05:00
Michael B. Gale
b46c2ee59b Merge pull request #4221 from github/mbg/macos27/warn
Check for versions of macOS and Xcode that are unsupported for traced analysis
2026-10-30 13:18:49 +00:00
Michael B. Gale
c56bb9b85b Fix checks if FF is disabled test using the wrong predicate 2026-10-30 13:00:33 +00:00
Michael B. Gale
b5b3ef7c6a Fix Xcode skip on self-hosted runner test 2026-10-30 12:59:24 +00:00
Michael B. Gale
3ecc7a9b7d Add change note 2026-10-30 12:56:44 +00:00
Michael B. Gale
99441b422c Merge pull request #4277 from github/dependabot/github_actions/dot-github/workflows/actions-minor-d87422eef0
Bump actions/setup-python from 7.0.0 to 7.1.0 in /.github/workflows in the actions-minor group across 1 directory
2026-10-30 11:40:43 +00:00
Michael B. Gale
f583e03df6 Remove unnecessary lstatSync call 2026-10-30 11:24:30 +00:00
Michael B. Gale
c6cc137b27 Fix assertions and features for tests 2026-10-30 11:10:38 +00:00
Michael B. Gale
251f480fa3 Use correct version constant in handleUnsupportedVersion baseMessage 2026-10-30 11:02:47 +00:00
Michael B. Gale
688c04ad4c Remove if option for validation jobs 2026-10-30 11:01:35 +00:00
Michael B. Gale
5bdb913da1 Rename FF to include "Abort" instead of "Skip" 2026-10-30 11:00:42 +00:00
Michael B. Gale
b2bb71bc61 Set tempDir in all createTestConfig calls in traced.test.ts
To avoid stray diagnostic files ending up in the working directory
2026-10-30 10:58:21 +00:00
Michael B. Gale
239b07849d Only skip Xcode check on self-hosted runners 2026-10-30 10:56:23 +00:00
Michael B. Gale
d37c3131f4 Improve comment/log message wording 2026-10-30 10:52:53 +00:00
Mario Campos
68a9dcbb35 Prefer == true over != false 2026-10-29 19:46:00 -05:00
Mario Campos
1304cc4df1 Potential fix for pull request finding 'CodeQL / Missing space in string concatenation'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2026-10-29 11:37:40 -05:00
Michael B. Gale
3da973862d Add debug-level log messages when checks are skipped 2026-10-29 16:35:49 +00:00
Michael B. Gale
019a5caccd Change log level of messages in xcodeVersion 2026-10-29 16:33:54 +00:00
Mario Campos
94f0998581 Avoid creating resolved comments without an existing warning
Use a boolean --create-if-missing flag, supplied by the composite action by default and omitted for resolution updates.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-29 11:32:57 -05:00
Michael B. Gale
8cafec0756 Skip checks on self-hosted runners 2026-10-29 16:30:21 +00:00
Mario Campos
e9651489af Avoid non-null assertion operators by asserting arguments 2026-10-29 10:44:10 -05:00
Mario Campos
9359b6b571 Wrap --marker argument in HTML comment tags automatically 2026-10-29 10:34:12 -05:00
Mario Campos
19e1ab5452 Update pr-checks/post-comment.ts description comment 2026-10-29 10:28:26 -05:00
Mario Campos
f13bcf383f Warn if more than one marked comment was found 2026-10-29 10:20:21 -05:00
Mario Campos
5bb3554330 Make input-validation assertions more granular 2026-10-29 10:13:06 -05:00
Mario Campos
87cac24cdd Avoid sparse checkout
This codebase is a tad coupled; it could end up biting us.
2026-10-29 10:03:32 -05:00
Mario Campos
2902eeab4d Checkout main instead of PR's base for the post-pr-comments job 2026-10-29 10:01:27 -05:00
Mario Campos
56fa196def Use YAML multiline string for the Action's inputs' descriptions 2026-10-29 09:58:48 -05:00
Mario Campos
3fb676f638 Use existing RepositoryNwo type 2026-10-29 09:56:18 -05:00
Mario Campos
afaf324646 Move resolveToken to pr-checks/api-client.ts 2026-10-29 09:51:48 -05:00
Henry Mercer
2d7aeadbf0 Merge pull request #4276 from github/dependabot/npm_and_yarn/npm-minor-7af0a5998a
Bump the npm-minor group across 1 directory with 2 updates
2026-10-29 10:46:05 +00:00
Mario Campos
c069d49e81 Test sticky comments using observable state
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-28 16:46:41 -05:00
Mario Campos
36f220a96c Remove unused post-comment step IDs
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-28 16:08:22 -05:00
Mario Campos
03137fc68d Rename changelog outputs to modified
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-28 16:06:08 -05:00
Mario Campos
94488778fd Simplify post-comment to a single set-comment mode
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-28 16:00:37 -05:00
Mario Campos
ae23865548 Move comment branching into workflow steps
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-28 15:53:36 -05:00
Mario Campos
90d1bc983c Remove bespoke post-comment argument validation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-28 15:39:43 -05:00
Mario Campos
ae9f97bade Make post-comment marker configurable
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-28 15:30:49 -05:00
github-actions[bot]
931fefa4bc Rebuild 2026-10-28 18:00:29 +00:00
dependabot[bot]
1b863a0649 Bump actions/setup-python
Bumps the actions-minor group with 1 update in the /.github/workflows directory: [actions/setup-python](https://github.com/actions/setup-python).


Updates `actions/setup-python` from 7.0.0 to 7.1.0
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](5fda3b95a4...6d4fd22b20)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 7.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-10-28 17:57:49 +00:00
dependabot[bot]
1965df5d2e Bump the npm-minor group across 1 directory with 2 updates
Bumps the npm-minor group with 2 updates in the / directory: [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) and [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc).


Updates `@types/sinon` from 22.0.0 to 22.0.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon)

Updates `eslint-plugin-jsdoc` from 65.3.15 to 65.4.0
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v65.3.15...v65.4.0)

---
updated-dependencies:
- dependency-name: "@types/sinon"
  dependency-version: 22.0.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm-minor
- dependency-name: eslint-plugin-jsdoc
  dependency-version: 65.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-10-28 17:54:58 +00:00
Michael B. Gale
ad2b30ba0f Use new FF in e2e test 2026-10-28 13:29:20 +00:00
Michael B. Gale
99971dd136 Gate checks behind FF 2026-10-28 13:19:40 +00:00
Michael B. Gale
202d9f1a6b Add CheckUnsupportedTracedAnalysis FF 2026-10-28 13:13:15 +00:00
Michael B. Gale
17685f3eba Add e2e test 2026-10-28 13:01:50 +00:00
Michael B. Gale
87ef6f5834 Return early if we are not on macOS to avoid unnecessary work 2026-10-28 13:01:49 +00:00
Michael B. Gale
84e80cea7e Avoid producing the same-ish message twice 2026-10-28 13:01:49 +00:00
Michael B. Gale
5547a3567f Only create diagnostics for traced languages 2026-10-28 13:01:49 +00:00
Michael B. Gale
eff66e8fb1 Make Xcode regex more flexible 2026-10-28 13:01:49 +00:00
Michael B. Gale
97b90230e5 Clarify that we are looking at the Darwin version 2026-10-28 13:01:49 +00:00